Update the way sh:targetClass of box.getLabel() is rendered.#168
Open
cecemel wants to merge 1 commit intosparna-git:masterfrom
Open
Conversation
The orginal comment stated `use the sh:targetClass if present, otherwise use the URI of the NodeShape` This commit changes the behaviour of the method that it matches the comment. Or at least the way I could interpret it. We could also consider adding this feature as a CLI option.
Contributor
|
No, the behavior is correct, it is the comment that is wrong :-) |
Contributor
Author
|
Thanks for the feedback; if I have time I'll try to have a shot through the CLI. Any suggestion on the argument name? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The orginal comment stated
use the sh:targetClass if present, otherwise use the URI of the NodeShapeThis commit changes the behaviour of the method that it matches the comment. Or at least the way I could interpret it.
We could also consider adding this feature as a CLI option.